Use Conditions from apimachinery, specifically k8s.io/apimachinery/pk… #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1644 +/- ##
==========================================
+ Coverage 75.53% 75.55% +0.01%
==========================================
Files 166 166
Lines 15159 15159
==========================================
+ Hits 11451 11454 +3
+ Misses 3406 3404 -2
+ Partials 302 301 -1
|
joshuatcasey
force-pushed
the
jtc/use-conditions-from-apimachinery
branch
2 times, most recently
from
b290a8a to
3da8f00
Compare
joshuatcasey
changed the base branch from
main
to
multiple_idps_and_transformations
joshuatcasey
changed the base branch from
multiple_idps_and_transformations
to
main
joshuatcasey
force-pushed
the
jtc/use-conditions-from-apimachinery
branch
3 times, most recently
from
cc91203 to
039a163
Compare
joshuatcasey
force-pushed
the
jtc/use-conditions-from-apimachinery
branch
from
039a163 to
b1bd05d
Compare
cfryanr
force-pushed
the
jtc/use-conditions-from-apimachinery
branch
from
b1bd05d to
34cc78d
Compare
|
I looked at what the merge conflicts would be in detail by running a trial merge and they aren't that bad, so I think we can go ahead and merge this now. I rebased main into the PR branch and will mark it for auto-merge. |
…g/apis/meta/v1.Conditions
cfryanr
force-pushed
the
jtc/use-conditions-from-apimachinery
branch
from
34cc78d to
64f1bff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Conditions from apimachinery, specifically
k8s.io/apimachinery/pkg/apis/meta/v1.ConditionsProbably try to merge #1646 and make all required pipeline changes before running this through the pipelines.
Release note: